Inconsistent number of listings between website search and admin search

[highnote]

Hello All,

Version: 3.2
I have been working with support to attempt duplication and wanted to see if others could help to duplicate.
This sighting can be duplicated when there are deactivated listings in the database that had not been deleted and there are greater than 20 active listings.

I found this using the trial database when I attempted to "deactivate" all 51 sample listings that came with the installation.  (I did not delete the listings.)  After I deactivated all of the listings I could find, I went back to the front-end of the website and did a search expecting "no ads found," however, 11 listings were displayed. I went back to the admin search and the active ads were not visible from the admin search screen. 

Another side-effect is that each time I deactivate some listings, the total number of listings seems to decrease in the admin search.  After deactivating all active listings viewable, there were only 20 total listings (one page, all deactivated) viewable from the admin search.  Since this is the admin search, the total number of listings should not decrease because the admin search displays both active and deactivated listings.  When I reactivated all of those listings, another page of listings showed up for a total of 40 listings.  I then reactivated the second page of listings, and a 3rd page showed up for a total of 51 listings.

Please see if you can help duplicate this and let us know your results.
Thanks,
Lou

[apn3a]

Unfortunately, i reproduced the above bug. I added 20+ listings to the database and they all showed up on the specific search.  Afterwards, I deactivated all of them and I became a little suspicious as only 20 listings were coming up and whichever ones were deactivated, would just disappear.  So I did a search through the website and found that a lot of the deactivated listings were still coming up, 11 to be exact. 

I also noticed that when you hit "Check All" and click "Activate," they don't actually activate.  And I just began to activate all of the inactive listings and the ones that weren't appearing before (the inactive one) began to magically appear.  I was worried that the "Deactivate Expired Listings" tab was not working, but that seems to work.  However, I find it that the "Search & Edit Listings" tab under the "Listing Data Management" is full of bugs.  The functions/actions and results of the Search & Edit Listings needs to be fixed and cleared of its bugs/errors/glitches.

I hope iAuto support figures out a solution to this soon as we cannot launch our website with such critical bugs.

[Smart Girl]

We'll fix this, be sure!

[apn3a]

has this issue been resolved yet?

[Smart Girl]

Yes, we have fixed this issue.

You may find patch here at: http://forum.iautosoftware.com/index.php/topic,174.0.html.

[highnote]

After uploading the patch, I still see the problem (perhaps I did not implement the patch properly).  I will describe what I did and the error mode.

Patch installation:

• Copied the new admin db_search.php into .../classifieds/admin/functions
• Copied the new unknown.php into .../classifieds/classes
• Copied the new user db_search.php with into .../classifieds/user/functions
      (note that I modified this file with the recently added unique VIN Check functionality "added by vs")

Using the Import in Admin console, I added some dummy vehicles so that the total number of vehicles is > 30

Defect Replication:

• Go to the front end of the website and do a Quick Search and just hit "GO"
• Count the number of Vehicles
• Go to the admin console - Listing Data Management - Search & Edit Listings - Quick Search and just hit "GO"
• Count the number of Vehicles

The number of vehicles is still different.  The problem is the Admin query is not displaying all of the vehicles (It stops precisely after displaying the first page of 20)

iAuto support: I have left all of the dummy vehicles in my database for you to duplicate.  Please let me know when I may deactivate these.
Thanks,
Lou

[Smart Girl]

highnote

Unfortunately, I reproduced the bug. 
We will investigate this issue.

[highnote]

Dear iAuto Support,
I noticed you had modified my get_main_pages function on June 6 and it appears to have fixed this problem based on our testing  , but I had not heard back if you are finished testing with my database.  Are you now finished and may I delete the dummy vehicles in the database?

Good work and thanks,
Lou

[Smart Girl]

Yes, you may delete them.

Thank you for your kind words!

[apn3a]

so has the patch been updated? or is it still the same at http://forum.iautosoftware.com/index.php/topic,174.0.html because i noticed the date on the file says May 23rd.

[highnote]

I upgraded to 3.4 and have not seen this latest change in the release.  The change is in the query strings (both were changed) where the new code adds the qualifier 'WHERE active = 0' OR 'active = 1' See the function get_main_pages() from unknown.php below.  They passed a new variable as well and added this variable in the function call from both the regular db_search.php and the db_search.php in the admin directory.

The function call to get_main_pages() in db_search.php must be modified to pass a variable depending on admin or frontend.  For the main db_search.php:
            $pages=get_main_pages($data_array,$num_per_page, "frontend");
The function call in db_search.php of the admin directory is modified as follows:
            $pages = get_main_pages($data_array, $num_per_page, 'admin');

This fixes the issue I had where the admin console did not find all of the listings.  The most recent version of get_main_pages() is below in unknown.php   
Regards,
Lou

-----------------------------------------------------------------------------------------------
function get_main_pages($data_array, $num, $mod)
{
   $formid=$data_array['formid'];
   
   if ($mod == 'frontend')
      $sql='SELECT `id` FROM `main` WHERE active=1';
   else
      $sql='SELECT `id` FROM `main` WHERE active=1 OR active=0';
   
   foreach($data_array['records'] as $recid=>$column) {
      $sql.=sql_request($column);
   }

   if(($r=mysql_query($sql))==false)
   {
      add_error('get_pages','SQL request error.',$sql,mysql_errno().": ".mysql_error());
      return false;
   }

   return ceil(mysql_num_rows($r)/$num);
}

[apn3a]

Hey Lou,

Thanks for that, I just changed them all on my copy.

-Minas